Skip to content

Fix typo in code comment #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

lkb85
Copy link
Contributor

@lkb85 lkb85 commented Feb 5, 2025

Minor typo fixes in comments.

Changed files:

  • core/src/main/java/org/springframework/ldap/odm/typeconversion/impl/ConverterManagerImpl.java
  • test/integration-tests/src/test/java/org/apache/directory/server/core/avltree/ArrayMarshaller.java

This change does not include functional changes.

@jzheaux
Copy link
Collaborator

jzheaux commented Feb 12, 2025

Hi, @lkb85, are you able to add the needed DCO sign-off to your commit?

@jzheaux
Copy link
Collaborator

jzheaux commented Mar 11, 2025

Hi, @lkb85. Thanks for the contribution. Can you please sign off on your commit so that it can be merged?

@jzheaux jzheaux added this to the 3.2.14 milestone Jul 17, 2025
jzheaux added a commit that referenced this pull request Jul 17, 2025
See gh-998

Co-Authored-By: kibeom lee <46297213+lkb85@users.noreply.github.com>
jzheaux added a commit that referenced this pull request Jul 17, 2025
See gh-998

Co-Authored-By: kibeom lee <46297213+lkb85@users.noreply.github.com>
jzheaux added a commit that referenced this pull request Jul 17, 2025
See gh-998

Co-Authored-By: kibeom lee <46297213+lkb85@users.noreply.github.com>
@jzheaux
Copy link
Collaborator

jzheaux commented Jul 17, 2025

Thanks again for the typo fixes, @lkb85.

Sadly, without your sign-off, I'm unable to merge this PR.

Instead, I made the change myself in 4146848 and marked you as a co-author.

For your next PR, please take a look at the DCO documentation so your commit contains the needed sign-off.

@jzheaux jzheaux closed this Jul 17, 2025
@jzheaux jzheaux self-assigned this Jul 17, 2025
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug status: declined A suggestion or change that we don't feel we should currently apply labels Jul 17, 2025
@jzheaux jzheaux removed this from the 3.2.14 milestone Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants